Add support for SSH BMC provider #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Dec 5, 2018
|
Looks like you need to silence the quoted boolean puppet-lint check. Other than that I think this looks good. |
|
Added ignore:quoted_booleans around poweron and powerstatus commands. |
ekohl
approved these changes
Dec 15, 2018
|
It turns out these parameters are incorrect: theforeman/smart-proxy#626. Going to send a PR to fix it before releasing it. |
|
Since this module is apparently in no wide use yet, I suggest to fix smart-proxy codebase and keep puppet and config as is. Rebased the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the SSH BMC provider and all configuration options that come with it. Defaults have been copied from the official foreman docs.