remote_execution ssh_user management #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
remote_execution_user
branch
3 times, most recently
from
86bf8cc
to
d806a47
Compare
ekohl
reviewed
Jan 29, 2019
| class foreman_proxy::plugin::remote_execution::ssh_user::params { | ||
|
|
||
| if defined('$::remote_execution_create_user') { | ||
| $remote_execution_create_user = str2bool($::remote_execution_create_user) |
There was a problem hiding this comment.
I think it makes more sense to name the variable manage_user to have parity with the class parameter
There was a problem hiding this comment.
Fixed. All variables in params.pp now match the class variable names.
alexjfisher
force-pushed
the
remote_execution_user
branch
from
d806a47
to
b036f9e
Compare
ekohl
reviewed
Feb 6, 2019
alexjfisher
force-pushed
the
remote_execution_user
branch
from
b036f9e
to
49f4d82
Compare
ekohl
reviewed
Mar 4, 2019
alexjfisher
force-pushed
the
remote_execution_user
branch
from
49f4d82
to
19d8157
Compare
ekohl
approved these changes
Mar 6, 2019
Especially useful if you have... * Hosts that were built before you discovered/enabled remote execution * You rebuild your foreman proxy server and the ssh keys are regenerated
alexjfisher
force-pushed
the
remote_execution_user
branch
from
a0f24cc
to
bfdd42b
Compare
|
@ekohl Comment added to params.pp and spec test (where I'm slightly abusing All rebased, squashed, signed and ready to merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially useful if you have...