-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #25481 - Manage foreman_proxy's ssh config #485
Conversation
This overrides the system wide ssh client config for ProxyCommand allowing the Ansible plugin to work on systems that have been configured as IPA clients.
@alexjfisher, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:
If changing the ticket number used, remember to update the PR title and the commit message (using This message was auto-generated by Foreman's prprocessor |
Ticket was moved to Installer Project. Closing and reopening the PR wasn't enough to trigger the bot. Maybe a new comment, (this comment), will? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm debating what the correct fix is. Should REX add -o ProxyCommand=none
to its execution instead? We can do a cherry pick of the plugins. @adamruzicka / @iNecas?
If I recall this only affects ansible runs, so adding properly escaped |
@ekohl I think you're probably right. I'll leave this open for now in case you change your mind! :) |
Any agreement on this? The proposed solution by Alex works well and is easy to inspect: would be nice to have it included in the upcoming 1.22 release, isn't it? ;-) |
How about #511 instead? Feels a bit lighter. |
The alternative has been merged. |
as per findings in https://projects.theforeman.org/issues/25481#note-10, it seems this was a better option, I'll need to check if this is specific to debian environment though |
@ares I've restored the branch, but github still won't let me reopen this PR. Let me know if you want me to open a new one. |
Thanks, I'm investigating other options to fix this, I'll get back to this if I don't find a better option. |
This overrides the system wide ssh client config for ProxyCommand
allowing the Ansible plugin to work on systems that have been configured
as IPA clients.