Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25481 - Manage foreman_proxy's ssh config #485

Closed
wants to merge 1 commit into from

Conversation

alexjfisher
Copy link
Contributor

This overrides the system wide ssh client config for ProxyCommand
allowing the Ansible plugin to work on systems that have been configured
as IPA clients.

This overrides the system wide ssh client config for ProxyCommand
allowing the Ansible plugin to work on systems that have been configured
as IPA clients.
@theforeman-bot
Copy link
Member

@alexjfisher, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:

If changing the ticket number used, remember to update the PR title and the commit message (using git commit --amend).


This message was auto-generated by Foreman's prprocessor

@alexjfisher
Copy link
Contributor Author

Ticket was moved to Installer Project. Closing and reopening the PR wasn't enough to trigger the bot. Maybe a new comment, (this comment), will?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debating what the correct fix is. Should REX add -o ProxyCommand=none to its execution instead? We can do a cherry pick of the plugins. @adamruzicka / @iNecas?

@adamruzicka
Copy link
Contributor

If I recall this only affects ansible runs, so adding properly escaped --ssh-common-args="-o ProxyCommand=none" to its execution (somewhere around here) might do the trick.

@alexjfisher
Copy link
Contributor Author

@ekohl I think you're probably right. I'll leave this open for now in case you change your mind! :)

@andreamtp
Copy link

Any agreement on this? The proposed solution by Alex works well and is easy to inspect: would be nice to have it included in the upcoming 1.22 release, isn't it? ;-)

@ekohl
Copy link
Member

ekohl commented Jun 6, 2019

How about #511 instead? Feels a bit lighter.

@ekohl
Copy link
Member

ekohl commented Jul 29, 2019

The alternative has been merged.

@ekohl ekohl closed this Jul 29, 2019
@alexjfisher alexjfisher deleted the 25481 branch July 30, 2019 09:14
@ares
Copy link
Member

ares commented Sep 17, 2019

as per findings in https://projects.theforeman.org/issues/25481#note-10, it seems this was a better option, I'll need to check if this is specific to debian environment though

@alexjfisher alexjfisher restored the 25481 branch September 18, 2019 08:44
@alexjfisher
Copy link
Contributor Author

@ares I've restored the branch, but github still won't let me reopen this PR. Let me know if you want me to open a new one.

@ares
Copy link
Member

ares commented Sep 19, 2019

Thanks, I'm investigating other options to fix this, I'll get back to this if I don't find a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants