Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ansible's stdout_callback to yaml for nicer output #492

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

iNecas
Copy link
Member

@iNecas iNecas commented Feb 21, 2019

Before:

ansible-stdout-before

After:

ansible-stdout-after

@iNecas
Copy link
Member Author

iNecas commented Feb 21, 2019

For some reason, I see stdout_lines in output by foreman, while when running from command line, I see stdout_lines: <omitted>, which makes the output even nicer. Not sure if that's something related to my local setup. Anyway, I still think the output is much nicer than the default one.

@ares
Copy link
Member

ares commented Feb 21, 2019

LGTM, if no one objects, I'll merge :-) the output is definitely more readable

@ekohl
Copy link
Member

ekohl commented Feb 22, 2019

We use the same one in forklift. The only downside there is that commands that have colors show the literal escape codes. Not sure if here you'd have the same problem.

@iNecas
Copy link
Member Author

iNecas commented Feb 25, 2019

We have support for color codes in foreman_ansible, so that should be fine

@ekohl ekohl merged commit 74a1988 into theforeman:master Feb 25, 2019
@ekohl
Copy link
Member

ekohl commented Feb 25, 2019

Thanks!

@ares
Copy link
Member

ares commented Feb 26, 2019

Thanks @iNecas, merging!

@ares
Copy link
Member

ares commented Feb 26, 2019

oh lol, github page didn't reload until I wrote a comment, then realized it's already merged, so thanks also @ekohl :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants