Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle smart proxy and plugins packaged for SCL #538

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Oct 1, 2019

No description provided.

@ehelms
Copy link
Member Author

ehelms commented Oct 1, 2019

Repository with all packages for testing -- https://fedorapeople.org/groups/katello/scl-proxy/

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd expose plugin_prefix as a parameter so users can still use the module with older versions. It'd have an upgrade warning, but various users do use the latest releases on older versions. It'd lead to complicated code in the dynflow plugin though.

manifests/plugin/dynflow.pp Outdated Show resolved Hide resolved
@ehelms ehelms requested a review from ekohl October 2, 2019 12:44
@ehelms ehelms marked this pull request as ready for review October 2, 2019 12:44
manifests/plugin/dynflow.pp Outdated Show resolved Hide resolved
manifests/plugin/dynflow.pp Outdated Show resolved Hide resolved
@evgeni
Copy link
Member

evgeni commented Jan 10, 2020

I think we'll also have to adjust

if $::osfamily == 'RedHat' and versioncmp($::operatingsystemmajrelease, '7') <= 0 and fact('ipaddress6') {
$bind_host = ['::']
} else {
$bind_host = ['*']
}
now that we use Ruby 2.5 and not 2.0 anymore (not strictly required in this PR, but for for overall ProxySCL feature)

manifests/params.pp Outdated Show resolved Hide resolved
manifests/plugin/dynflow.pp Outdated Show resolved Hide resolved
spec/defines/foreman_proxy_plugin_spec.rb Outdated Show resolved Hide resolved
@ehelms ehelms force-pushed the handle-scl-packages branch 2 times, most recently from c73b16a to d20c89b Compare January 13, 2020 13:30
@ehelms
Copy link
Member Author

ehelms commented Jan 13, 2020

Updates that include changing bind_host, related installer PR theforeman/foreman-installer#447

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekohl any further comments from your side?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Leaving it open so we can merge it together with the others.

@ehelms ehelms merged commit 32b61e3 into theforeman:master Jan 15, 2020
@ehelms ehelms deleted the handle-scl-packages branch January 15, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants