-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle smart proxy and plugins packaged for SCL #538
Conversation
e6e57cb
to
033cecf
Compare
Repository with all packages for testing -- https://fedorapeople.org/groups/katello/scl-proxy/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd expose plugin_prefix
as a parameter so users can still use the module with older versions. It'd have an upgrade warning, but various users do use the latest releases on older versions. It'd lead to complicated code in the dynflow plugin though.
033cecf
to
fd8ecf1
Compare
fd8ecf1
to
d982c88
Compare
8e4da87
to
1a55370
Compare
28be0a1
to
91a2e7f
Compare
c267f7f
to
f78b08c
Compare
I think we'll also have to adjust puppet-foreman_proxy/manifests/params.pp Lines 122 to 126 in eb3ad13
|
c73b16a
to
d20c89b
Compare
Updates that include changing |
d20c89b
to
8f52dd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ekohl any further comments from your side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. Leaving it open so we can merge it together with the others.
No description provided.