Add Pulp 3 HTTP URLs #549
Merged
Add Pulp 3 HTTP URLs #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Dec 6, 2019
| @@ -25,6 +25,10 @@ | |||
| # | |||
| # $pulp3_mirror:: Whether this pulp3 plugin acts as a mirror or another pulp node. A pulp3 mirror is the pulp3 equivalent of a pulpnode. | |||
| # | |||
| # $pulp3_api_url:: The URL to the Pulp 3 API | |||
| # | |||
| # $pulp3_content_url:: The URL to the Pulp 3 content | |||
There was a problem hiding this comment.
We've already used this convention in a few places, but in others we've identified that the use of pulp3 may come back to bite us and used pulpcore.
There was a problem hiding this comment.
I don't mind renaming. Most of these predate the pulpcore convention. In https://github.com/theforeman/smart_proxy_pulp/ it's also the pulp3 module.
There was a problem hiding this comment.
Let's merge this and I'll raise an issue here to discuss further.
ehelms
approved these changes
Dec 6, 2019
|
@jlsherrill these defaults make sense, right? Or should we default to the public URLs? |
This matches the pulp3.yml.example file with defaults that match what theforeman-foreman_proxy_content deploys.
|
Updated to the public URLs by default to match how we deploy this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the pulp3.yml.example file with defaults that match the theforeman-pulpcore defaults.