Fixes #30950 - Enable SmartProxy Registration module #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Oct 1, 2020
There was a problem hiding this comment.
Please also write in the compatibility section in README.md that users on older versions should disable the module since it doesn't exist.
You may also need to create a template for the settings.
Acceptance tests will fail until it's merged in the smart proxy, but at least the unit tests can pass before that.
theforeman-bot
added
Waiting on contributor
Needs re-review
and removed
Not yet reviewed
Waiting on contributor
labels
stejskalleos
force-pushed
the
ls/registration_module
branch
from
ab5b448
to
cf15e0d
Compare
stejskalleos
changed the title
ekohl
reviewed
Oct 5, 2020
stejskalleos
force-pushed
the
ls/registration_module
branch
from
cf15e0d
to
f45e805
Compare
stejskalleos
force-pushed
the
ls/registration_module
branch
from
f45e805
to
e4d0d6f
Compare
ekohl
reviewed
Oct 13, 2020
| ) { | ||
| foreman_proxy::module { 'registration': | ||
| enabled => $enabled, | ||
| feature => 'Registration', |
There was a problem hiding this comment.
Note to self: confirmed that this matches Foreman's feature name (theforeman/foreman@31b0d19)
stejskalleos
force-pushed
the
ls/registration_module
branch
from
03d643a
to
3c387b0
Compare
|
After a quick clarification, the pending thing here is to enforce https for this module. Then should be good to go. |
stejskalleos
force-pushed
the
ls/registration_module
branch
from
3c387b0
to
e743e5a
Compare
stejskalleos
force-pushed
the
ls/registration_module
branch
from
e743e5a
to
8e16fd2
Compare
ekohl
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for: theforeman/smart-proxy#768
PR is part of Simple & automatic host registration WF, see: