Refs #29830 - Move discovery plugin docs to RDOC and split out advanced parameters

[ehelms]

No description provided.

[wbclark]

I think that as long as we are making these changes, we could improve the documentation of these parameters a bit.

[wbclark]

Outside the scope of this PR, but:

I'd argue that this should in fact refer to the full URL of the file. I don't see the use case for having 2 separate parameters and simply concatenating them. It maybe makes our job a little easier as we refer to the $image_name separately for example at

puppet-foreman_proxy/manifests/plugin/discovery.pp

Line 32 in d2f07f4

} ~> exec { "untar ${image_name}":

but it would be better for the user to have $source_url and $image_name combined to a single parameter I think.

[ekohl]

I disagree. For example, you mirror it somewhere and only change the base URL while still using the same imagine name as upstream. Another example could be branding where you change the source URL to your company name. It also makes the code a lot harder because now you need to split some URL. That's always painful and a good source of bugs. Given these are advanced parameters, I wouldn't change this.

[ekohl]

Should this refer to https://projects.theforeman.org/issues/29830?