Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellhooks plugin #651

Merged
merged 3 commits into from
Mar 23, 2021
Merged

Add shellhooks plugin #651

merged 3 commits into from
Mar 23, 2021

Conversation

adamruzicka
Copy link
Contributor

No description provided.

@adamruzicka
Copy link
Contributor Author

If I understand what's going on, enabling the shellhooks plugin will fail until theforeman/foreman_webhooks#25 is merged and released.

@adamruzicka
Copy link
Contributor Author

If I understand what's going on, enabling the shellhooks plugin will fail until theforeman/foreman_webhooks#25 is merged and released.

And as a followup, if shellhooks requires a feature on the foreman side which is created by foreman_webhooks, should enabling smart_proxy_shellhooks also enable foreman_webhooks?

adamruzicka and others added 2 commits March 4, 2021 14:18
Co-authored-by: Eric Helms <eric.d.helms@gmail.com>
@lzap
Copy link
Member

lzap commented Mar 22, 2021

The comment was fixed upstream.

@ehelms ehelms merged commit 3f0cb34 into theforeman:master Mar 23, 2021
@adamruzicka adamruzicka deleted the shellhooks branch March 23, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants