Default package versions to installed instead of present #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release of puppetlabs-stdlib included a change to ensure_packages that defaults to installed rather than present. Additionally, if ensure_packages provides an override set to present, this is internally converted to installed. Thus any previous test that checked for present fails. This updates the tests to check for installed and updates the defaults within the module from present to installed to match the default behavior of ensure_packages. Ref: puppetlabs/puppetlabs-stdlib@842992e
ekohl
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release of puppetlabs-stdlib included a change to ensure_packages
that defaults to installed rather than present. Additionally, if
ensure_packages provides an override set to present, this is internally
converted to installed. Thus any previous test that checked for present
fails.
This updates the tests to check for installed and updates the defaults
within the module from present to installed to match the default behavior
of ensure_packages.
Ref: puppetlabs/puppetlabs-stdlib@842992e