Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setfacl needs foreman_proxy::user to exist #719

Merged
merged 1 commit into from
Jan 12, 2022
Merged

setfacl needs foreman_proxy::user to exist #719

merged 1 commit into from
Jan 12, 2022

Conversation

eb4x
Copy link
Contributor

@eb4x eb4x commented Jan 4, 2022

There's a race-condition in config.pp where the inclusion of
proxydhcp.pp can run setfacl before the user is created.

@eb4x eb4x changed the title We need the foreman_proxy::user to exist setfacl needs foreman_proxy::user to exist Jan 4, 2022
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, but I'd like to fix our pipelines first which broke due to unrelated reasons.

@ekohl
Copy link
Member

ekohl commented Jan 11, 2022

We fixed that in master. Could you rebase this?

There's a race-condition in config.pp where the inclusion of
proxydhcp.pp can run setfacl before the user is created.
@ekohl ekohl merged commit 574a320 into theforeman:master Jan 12, 2022
@ekohl
Copy link
Member

ekohl commented Jan 12, 2022

Thanks!

@ekohl ekohl added the Bug label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants