Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #34239: Add pull-mqtt support to smart_proxy_remote_execution #737

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Fixes #34239: Add pull-mqtt support to smart_proxy_remote_execution #737

merged 1 commit into from
Apr 22, 2022

Conversation

ehelms
Copy link
Member

@ehelms ehelms commented Apr 13, 2022

@ehelms ehelms mentioned this pull request Apr 13, 2022
Closed
@evgeni evgeni force-pushed the add-mqtt-pull branch 3 times, most recently from afaa279 to 408a630 Compare April 21, 2022 07:35
@evgeni
Copy link
Member

evgeni commented Apr 21, 2022

given all this builds upon is merged, I've rebased it and made the linter happy ;)

@evgeni
Copy link
Member

evgeni commented Apr 21, 2022

the test failures are legit ;)

@ehelms ehelms marked this pull request as ready for review April 21, 2022 12:48
@ehelms ehelms force-pushed the add-mqtt-pull branch 3 times, most recently from 305a32f to 4947221 Compare April 21, 2022 13:14
@ehelms ehelms changed the title Add mqtt pull Add pull-mqtt support to smart_proxy_remote_execution Apr 21, 2022
@ehelms ehelms force-pushed the add-mqtt-pull branch 2 times, most recently from 436c62e to da84dbb Compare April 21, 2022 13:33
@evgeni
Copy link
Member

evgeni commented Apr 22, 2022

Should mosquitto be cleaned up if the user decides to flip back to SSH?

evgeni
evgeni approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this addresses all points we had discussed over in #726.

Should this PR/commit ref/fix RM#34239? I think it should.

We can take the "switch from mqtt to ssh" question to another day/PR.

@ehelms
Copy link
Member Author

ehelms commented Apr 22, 2022

We can take the "switch from mqtt to ssh" question to another day/PR.

I started a separate PR dedicated to that -- #744 . I will work on the hard part -- tests to verify it works.

@ehelms
Copy link
Member Author

ehelms commented Apr 22, 2022 •
edited
Loading

Edit: I'm going to opt to pull this in so it can propagate through nightly. That will allow @adamruzicka to continue further development and testing and make adjustments if necessary.

@ehelms ehelms changed the title Add pull-mqtt support to smart_proxy_remote_execution Fixes #34239: Add pull-mqtt support to smart_proxy_remote_execution Apr 22, 2022
@ehelms ehelms merged commit d7be285 into theforeman:master Apr 22, 2022
@ehelms
Copy link
Member Author

ehelms commented Apr 22, 2022

I nearly forgot we need to add a hard dependency in the installer given puppet-mosquitto is a soft dependency in the module: theforeman/foreman-installer#760

@ehelms ehelms mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehelms @evgeni @theforeman-bot