also chain private keys from puppet-certs correctly #755

evgeni · 2022-05-05T07:53:22Z

No description provided.

evgeni · 2022-05-05T08:03:30Z

the problem is that ssl_key.pem in a Katello deployment is a private_key from the certs module, and while that does define a file internally (https://github.com/theforeman/puppet-certs/blob/5ce5b4b9e8a13a7a630cc607ecfa5e48991a2aa9/lib/puppet/type/private_key.rb#L64) those are not available for matching of a collector:

Collectors can search only on attributes that are present in the manifests

(the file resource is not in the manifest, the private_key is)

the problem is that `ssl_key.pem` in a Katello deployment is a `private_key` from the `certs` module, and while that *does* define a `file` internally (https://github.com/theforeman/puppet-certs/blob/5ce5b4b9e8a13a7a630cc607ecfa5e48991a2aa9/lib/puppet/type/private_key.rb#L64) those are not available for matching of a collector. https://puppet.com/docs/puppet/6/lang_collectors.html: > Collectors can search only on attributes that are present in the manifests (the `file` resource is not in the manifest, the `private_key` is)

theforeman-bot added Needs testing Not yet reviewed labels May 5, 2022

evgeni added the Bug label May 5, 2022

evgeni force-pushed the more-notify branch from d8a60e8 to 7414a29 Compare May 5, 2022 08:10

upadhyeammit approved these changes May 5, 2022

View reviewed changes

theforeman-bot removed the Not yet reviewed label May 5, 2022

evgeni merged commit 9319a59 into master May 5, 2022

evgeni deleted the more-notify branch May 5, 2022 08:59

Provide feedback