Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for Debian 10 Buster #766

Merged
merged 1 commit into from
Jul 20, 2022
Merged

drop support for Debian 10 Buster #766

merged 1 commit into from
Jul 20, 2022

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jun 29, 2022

No description provided.

ekohl
ekohl approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would ansible-runner come from? I see it's only in Debian 12 (https://packages.debian.org/bookworm/python3-ansible-runner) Ubuntu 21.10 (https://packages.ubuntu.com/impish/python3-ansible-runner). On the other hand, the old code wasn't doing anything useful either.

@evgeni
Copy link
Member Author

evgeni commented Jun 29, 2022 •
edited
Loading

For bullseye and focal, we have it in our packaging: https://deb.theforeman.org/pool/bullseye/nightly/a/ansible-runner/ https://deb.theforeman.org/pool/focal/nightly/a/ansible-runner/

ekohl
ekohl approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debating to doing a last release with all the minor enhancements but they're not that important.

@evgeni
Copy link
Member Author

evgeni commented Jun 30, 2022

@ekohl up to you, I don't mind/care either way

@ehelms
Copy link
Member

ehelms commented Jul 12, 2022

I'm debating to doing a last release with all the minor enhancements but they're not that important.

What's the decision here so we can take action on this PR?

@ekohl ekohl merged commit 18ac4a1 into master Jul 20, 2022
@ekohl ekohl deleted the drop-buster branch July 20, 2022 13:11
@ekohl
Copy link
Member

ekohl commented Sep 22, 2022

Looks like we should have included a migration for this in our installer: https://community.theforeman.org/t/foreman-plugins-3-4-deb-test-pipeline-4-failed/30543/2

@evgeni
Copy link
Member Author

evgeni commented Sep 22, 2022

Oh right, because even if we ensured the repo to be absent, the overall manage thing was true...

@ekohl
Copy link
Member

ekohl commented Sep 22, 2022

I at least opened https://projects.theforeman.org/issues/35553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Backwards incompatible Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evgeni @ehelms @ekohl @theforeman-bot