Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #37078 - ensure salt installation is done before configuration #826

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fixes #37078 - ensure salt installation is done before configuration #826

merged 1 commit into from
Feb 19, 2024

Conversation

knoppi
Copy link

@knoppi knoppi commented Jan 22, 2024

This PR adds a requirement in order to ensure the rubygem for salt in installed before puppet creates the foreman configuration.

ekohl
ekohl requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to add require => Foreman_proxy::Plugin::Module['salt'] to the foreman.conf resource.

manifests/plugin/salt.pp Show resolved Hide resolved
@ekohl ekohl merged commit 26c1255 into theforeman:master Feb 19, 2024
15 checks passed
@ekohl ekohl mentioned this pull request Feb 19, 2024
Merged
@maximiliankolb maximiliankolb deleted the 37078-salt_configuration_after_installation branch April 2, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
Bug
Projects
No open projects
Foreman 3.10 branching and GA
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knoppi @ekohl