Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.4.0 #188

Merged
merged 1 commit into from
May 19, 2021
Merged

Release 3.4.0 #188

merged 1 commit into from
May 19, 2021

Conversation

wbclark
Copy link
Collaborator

@wbclark wbclark commented May 4, 2021

No description provided.

CHANGELOG.md Show resolved Hide resolved
@ehelms
Copy link
Member

ehelms commented May 5, 2021

theforeman/puppet-foreman_proxy_content#350 does require a release of this module (or at least a version bump). Which would be preferred so that I can then update the metadata to require a new minimum version?

@wbclark wbclark marked this pull request as draft May 5, 2021 16:30
@wbclark
Copy link
Collaborator Author

wbclark commented May 5, 2021

theforeman/puppet-foreman_proxy_content#350 does require a release of this module (or at least a version bump). Which would be preferred so that I can then update the metadata to require a new minimum version?

  1. Do we want to get this into the next z-stream Foreman release ? (If so, I lean towards releasing here sooner)

  2. Are there other features here that should be in the next z-stream release ? (If so, we could get those in as well to avoid needing 2 releases)

If we'd like to consider this for z-stream and we aren't currently aware of other features here that would be desired in the same z-stream, I would say let's go ahead and do it. Otherwise I don't see any problem with updating metadata in devel branches only for now. Let me know what you think @ehelms

@ehelms
Copy link
Member

ehelms commented May 5, 2021

  • Do we want to get this into the next z-stream Foreman release ? (If so, I lean towards releasing here sooner)

No. This is a change for the next Foreman release not 2.5.

@ekohl
Copy link
Member

ekohl commented May 5, 2021

We can bump the module in git already but not release it. We've done this before. That way you can bump the metadata requirement already. In Voxpupuli it's also common to use a -rc0 suffix in git to distinguish the two.

@ehelms
Copy link
Member

ehelms commented May 6, 2021

PR to just bump the version -- #189

@wbclark wbclark marked this pull request as ready for review May 19, 2021 14:35
@@ -1,3 +1,20 @@
## [3.3.0](https://github.com/theforeman/puppet-pulpcore/tree/3.3.0) (2021-04-21)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the update here is to prevent changelog-generator from wanting to insert empty release notes for v2.2.3

@ehelms ehelms merged commit 102f666 into theforeman:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants