Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RuboCop task definition in Rakefile #130

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Aug 2, 2023

This turns on the GitHub formatter if GH Actions is detected, which provides nice inline annotations.

Right now I added a commit to force failures, which showcases the feature.

This replaces the last part of #104

@adamruzicka
Copy link
Contributor

@ekohl Hi, any plans with this?

This turns on the GitHub formatter if GH Actions is detected, which
provides nice inline annotations.
@ekohl
Copy link
Member Author

ekohl commented Oct 20, 2023

Rebased and dropped the last commit that enabled NewCops.

@adamruzicka adamruzicka merged commit ae01eef into theforeman:master Oct 23, 2023
5 of 7 checks passed
@adamruzicka
Copy link
Contributor

Thank you @ekohl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants