Refs #32534 - dont use SmartProxyDynflowCore #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamruzicka
reviewed
Jun 23, 2021
Comment on lines
21
to
23
| def on_proxy? | ||
| defined?(SmartProxyDynflowCore::Callback) | ||
| defined?(Proxy::Dynflow::Callback) | ||
| end |
There was a problem hiding this comment.
This should now always be true, the action cannot run anywhere else than on the smart proxy
There was a problem hiding this comment.
Do we want to remove that then and remove usage of it?
Or just return always true and have a followup?
There was a problem hiding this comment.
I feel the latter is what we want, so I went with it, I'll try to come up with follow-up
There was a problem hiding this comment.
It doesn't seem to be used outside of this repository so I'd be fine with removing it along with its usage in this pr
There was a problem hiding this comment.
Hah, github didn't refresh. Nevermind then, let's do it in a followup
Remove usage of SmartProxyDynflowCore.
ezr-ondrej
force-pushed
the
drop_core_deps
branch
from
70e8c21
to
fd81539
Compare
|
Thank you @ezr-ondrej ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of SmartProxyDynflowCore.