Drop Pulp 2 and update others #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the plugin is not running, it is useful to have the log buffer for the failed modules. This contains the error message while loading the module, making it much easier to debug. Also asserting that the response is ok is a good thing before anything else.
This makes the following work:
rake test TEST=test/pulpcore_plugin_integration_test.rb
Since Smart Proxy 2.1.0 there is a built in URL validator.
Previously it wasn't very clear where it got its config from. The PulpcoreApi implementation used the Pulp 3 URL but printed the Pulp 2 URL in case an error showed up. Now it only uses the Pulpcore plugin. a5501f9 dropped disk space usage but the require was forgotten.
Smart Proxy 2.3.0 introduced rackup_path which sets both http_rackup_path and https_rackup_path to the same value. Since this is what's done here, it simplifies the plugin definition.
There is no reason to use multiple lines for this.
jlsherrill
approved these changes
Feb 9, 2021
|
Do you think it's time to merge this? |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops all the Pulp 2 implementation code and only keeps the Pulpcore implementation. To do so, it cleans up some other code.