Use tsdx to build without transpiling generators #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview packages of this pull request have been published. effectionInstall using the following command: $ npm install effection@try-rollupOr update your package.json file: {
"effection": "try-rollup"
}@effection/eventsInstall using the following command: $ npm install @effection/events@try-rollupOr update your package.json file: {
"@effection/events": "try-rollup"
}@effection/nodeInstall using the following command: $ npm install @effection/node@try-rollupOr update your package.json file: {
"@effection/node": "try-rollup"
} |
cowboyd
reviewed
May 16, 2020
cowboyd
approved these changes
May 18, 2020
| @@ -1,4 +1,7 @@ | |||
| { | |||
| "extends": "./tsconfig", | |||
| "compilerOptions": { | |||
| "module": "esnext" | |||
There was a problem hiding this comment.
What's the default in @frontside/tsconfig or does it say?
There was a problem hiding this comment.
It defaults to module: "commonjs"
There was a problem hiding this comment.
It's a side discussion, but should it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We made a decision to ship generators in our distribution bundles because IE11 compatibility is not important to us. It's surprisingly difficult to get this to work. We tried using microbundle but that turned out to be even more complicated because their modern and cjs formats have mutually conflicting configuration.
Approach
I tried
tsdxbut it also transpiles generators by default. There is an RFC to make tsdx more customizable but in the mean time I patchedtsdxto exclude@babel/plugin-transform-regeneratorfrom Babel plugins using patch-package.patch-packageonpostinstallLearning
patch-package is pretty cool. It has a nice workflow. When you need to change a dependency, modify it's code in node_modules and run
npx patch-package <package_name>. It'll compare a fresh copy of the package that you're modifying to your changed copy and created a diff. It'll automatically apply this diff when you runyarn.