Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @interactors/with-storybook package #164

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

wKich
Copy link
Member

@wKich wKich commented Dec 7, 2021

Motivation

User can use interactors in storybook to write interactive stories, but interactions aren't trackable by storybook, so they are not visible in storybook interaction inspector.

Approach

Created a Storybook addon @interactors/with-storybook to be able show interactions in storybook inspector
Updated docs by adding guide how to use with-storybook addon

@wKich wKich requested a review from jnicklas December 7, 2021 12:12
@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2021

🦋 Changeset detected

Latest commit: 6e8a41d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@interactors/material-ui Patch
@interactors/with-storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from interaction-code to main January 31, 2022 10:31
@netlify
Copy link

netlify bot commented Mar 18, 2022

Deploy Preview for interactors canceled.

Name Link
🔨 Latest commit 6e8a41d
🔍 Latest deploy log https://app.netlify.com/sites/interactors/deploys/6242cecf31c1360008125212

@wKich wKich force-pushed the interactive-stories-v2 branch 3 times, most recently from 347226b to c2a1808 Compare March 21, 2022 13:30
@wKich wKich requested review from cowboyd and removed request for jnicklas March 21, 2022 13:53
@wKich wKich changed the title Use addActionWrapper to track actions in interactive stories debugger Add @interactors/with-storybook package Mar 22, 2022
@wKich wKich added documentation Improvements or additions to documentation enhancement New feature or request preview to publish preview packages material-ui labels Mar 23, 2022
Copy link
Contributor

@jorgelainfiesta jorgelainfiesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Dmitry!

website/docs/storybook.md Outdated Show resolved Hide resolved
[![Chat on Discord](https://img.shields.io/discord/700803887132704931?Label=Discord)](https://discord.gg/mv4uxxcAKd)

[Interactors][] are Page Objects for component libraries and design systems.
This package lets you use them seamlessly within [Storybook][] interactive stories. Learn more at
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add more content to this page as it'll be visible in Storybook's website. We might want to include a gif as featured here. We can do that in a separate PR but I think it's important

@frontsidejack
Copy link
Member

frontsidejack commented Mar 29, 2022

The following preview packages were published:

Name Version Install Command

@interactors/with-storybook

1.0.0-interactive-stories-v2.2

yarn add @interactors/with-storybook@interactive-stories-v2

@interactors/globals

1.0.0-interactive-stories-v2.2

yarn add @interactors/globals@interactive-stories-v2

@interactors/core

1.0.0-interactive-stories-v2.2

yarn add @interactors/core@interactive-stories-v2

@interactors/material-ui

5.0.0-interactive-stories-v2.2

yarn add @interactors/material-ui@interactive-stories-v2

Generated by @thefrontside/actions Frontside

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request material-ui preview to publish preview packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants