Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧑‍💻 Migrate to Deno for development #279

Merged
merged 12 commits into from
Sep 17, 2024
Merged

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Sep 16, 2024

Motivation

There are two main reasons that we want to migrate to Deno:

  1. The TS types that we currently ship with our interactors packages are broken, and rather than maintain and build the npm packages by hand, we can just use DNT to build them for us knowing that they'll be maximally compatible with NPM going forward.
  2. We're planning on using Deno to build the interactors CLI, so it would be nice to have that in place first.

Approach

Migrate to a single Deno workspace, and then use covector for change management and publication. Releases will represented via a tag, and then publication to package registries can happen independently.

Shout out to @wKich for doing the heavy lifting on this!

wKich and others added 10 commits August 8, 2024 17:50
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Signed-off-by: Dmitriy Lazarev <w@kich.dev>
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for interactors canceled.

Name Link
🔨 Latest commit 430a678
🔍 Latest deploy log https://app.netlify.com/sites/interactors/deploys/66e8f24e4698480008347715

@thefrontside thefrontside deleted a comment from changeset-bot bot Sep 16, 2024
Copy link
Contributor

github-actions bot commented Sep 16, 2024

Package Changes Through 430a678

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Contributor

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking lovely! Just a few comments on the package.json which we should check in every file / package.

packages/core/package.json Outdated Show resolved Hide resolved
packages/core/src/element/click.ts Outdated Show resolved Hide resolved
packages/keyboard/package.json Outdated Show resolved Hide resolved
packages/with-cypress/package.json Outdated Show resolved Hide resolved
@cowboyd cowboyd force-pushed the deno-monorepo-publish branch 3 times, most recently from ce955d4 to df3c773 Compare September 17, 2024 03:05
@cowboyd cowboyd merged commit cf59935 into main Sep 17, 2024
6 checks passed
@cowboyd cowboyd deleted the deno-monorepo-publish branch September 17, 2024 03:08
@@ -8,7 +8,7 @@
"repository": "https://github.com/thefrontside/interactors.git",
"homepage": "https://frontside.com/interactors",
"author": "Frontside Engineering <engineering@frontside.com>",
"license": "MIT",
n "license": "MIT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it's typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooooooooo! 😬

@cowboyd cowboyd mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants