Skip to content

Commit

Permalink
add note about commenting
Browse files Browse the repository at this point in the history
  • Loading branch information
fershad committed Oct 14, 2024
1 parent c238d96 commit 33c66d7
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,17 @@ Thank you for considering contributing to CO2.js. Open source is at the heart of
**NB** Changes/commits that are not linked to an issue will not be accepted.

### New issues
- Our issue template provides you with a scaffold to follow when raising a new issue. There are three formats to choose from:
1. *Bugs* - clearly describe the problem you're facing including steps to reproduce it. Please also be sure to include the information about the environment your code was running in (e.g. NodeJS, Deno, Edge Worker, Browser etc).
1. *New features* - clearly describe the new feature you'd like to see added and provide a reason for why it should be added. eg what will be improved/possible as a result of making your suggested change.
1. *Request addition of carbon estimation model to CO2.js* - please provide as much information about the model as possible including links to additional documentation and information about how the model is licensed.


- Our issue template provides you with a scaffold to follow when raising a new issue. There are three formats to choose from:
1. _Bugs_ - clearly describe the problem you're facing including steps to reproduce it. Please also be sure to include the information about the environment your code was running in (e.g. NodeJS, Deno, Edge Worker, Browser etc).
1. _New features_ - clearly describe the new feature you'd like to see added and provide a reason for why it should be added. eg what will be improved/possible as a result of making your suggested change.
1. _Request addition of carbon estimation model to CO2.js_ - please provide as much information about the model as possible including links to additional documentation and information about how the model is licensed.

## Making Changes

- Fork the repository on GitHub.
- Create a topic branch from where you want to base your work. This branch should usually be based off `main`.
- Remember to add JSDoc comments to any new functions or variables that you are introducing into the codebase.
- Make commits of logical units.
- Make commit messages clear and understandable.

Expand All @@ -28,10 +28,10 @@ Thank you for considering contributing to CO2.js. Open source is at the heart of
- Push the changes made in your branch to your fork of this repository.
- Submit a [pull request](https://github.com/thegreenwebfoundation/co2.js/pulls) to the CO2.js repository in the `thegreenwebfoundation` organization.
- When opening a new pull request, you'll see a template. Please follow it. It asks you to state:
- the type of change (choose from a list)
- link to the related issue
- what documentation needs updating as a result (choose from a list)
- what your changes are - be sure to clearly explain the changes you've made, any new files, dependencies, or network requests that have been added, and provide any additional context to help reviewers understand the changes made.
- the type of change (choose from a list)
- link to the related issue
- what documentation needs updating as a result (choose from a list)
- what your changes are - be sure to clearly explain the changes you've made, any new files, dependencies, or network requests that have been added, and provide any additional context to help reviewers understand the changes made.
- Your pull request will be reviewed by a maintainer from Green Web Foundation.
- After feedback has been given we expect responses within two weeks. After two weeks we may close the pull request if it isn't showing any activity.

Expand All @@ -43,4 +43,4 @@ Please note that this project is released with a [Contributor Code of Conduct](h

## Thank you

Again, thank you for your contributions. We appreciate your help improving CO2.js, and we look forward to your future contributions!
Again, thank you for your contributions. We appreciate your help improving CO2.js, and we look forward to your future contributions!

0 comments on commit 33c66d7

Please sign in to comment.