Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message customization #10

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Add message customization #10

merged 1 commit into from
Nov 22, 2021

Conversation

thehanimo
Copy link
Owner

Original PR: #9

New

  • Adds the ability to optionally customize the success and failure messages.
  • Adds the ability to optionally add a notice upon failure (for printing out the guidelines).
  • Removes "title needs formatting" label if PR has an ignore label applied
  • Backwards compatible, defaults to current messages if the new config section isn't found

Fixes

  • removeLabel had an unreferenced variable usage in the error handling
  • adds a missing await when invoking addLabel
  • no longer prints out success message when there's a failure

Refactored

  • pulled failure handling out of addLabel and into a new function called titleCheckFailed

@thehanimo thehanimo merged commit 58c2cda into main Nov 22, 2021
@thehanimo thehanimo deleted the add-message-customization branch November 22, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants