Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

In the electron versions, the menu seems to be broken. #353

Closed
owlJaeger opened this issue May 1, 2020 · 5 comments
Closed

In the electron versions, the menu seems to be broken. #353

owlJaeger opened this issue May 1, 2020 · 5 comments

Comments

@owlJaeger
Copy link

owlJaeger commented May 1, 2020

After compiling theia-electron and starting it, the menubar is mostly empty.

image

@owlJaeger
Copy link
Author

Looks like it's not only a bug with the electron version. I've changed the target to 'browser' and tested again. Also is broken...

image

@vince-fugnitto
Copy link
Member

Looks like it's not only a bug with the electron version. I've changed the target to 'browser' and tested again. Also is broken...

image

@owlJaeger what type of modifications did you make to theia-electron, changing the target should not be enough.

@vince-fugnitto
Copy link
Member

I see the following error:

menu.ts:274 Uncaught (in promise) Error: A command with id 'workspace:removeFolder' does not exist.
    at e.get [as label] (menu.ts:274)
    at e.get [as sortString] (menu.ts:288)
    at menu.ts:210
    at Array.sort (<anonymous>)
    at e.addNode (menu.ts:202)
    at e.registerMenuAction (menu.ts:83)
    at n.updateAddRemoveFolderActions (navigator-contribution.ts:496)
    at navigator-contribution.ts:168

@owlJaeger
Copy link
Author

In the package.json, I changed target to browser, ran yarn, yarn theia rebuild:browser and yarn theia start.

@vince-fugnitto
Copy link
Member

The issue has been fixed upstream: eclipse-theia/theia#7727

I confirmed that building 'theia-electron' now works successfully and the main-menu is rendered. If others want to fix the main-menu for their latest applications (including docker images) it is possible to use resolutions in the 'package.json' to resolve the issue:

"resolutions": {
  "**/**/moment": "2.24.0"
},

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants