bug: fix momentjs dependency

[vince-fugnitto]

What it does

Fixes: #7726

The following pull-request fixes the version range of momentjs which has been recently published causing an error which ultimately results in the main-menu not being rendered successfully. The issue has affecter our docker images, electron-builder example, and the 'composing applications' section of the website.

How to test

1. in this repo verify that the application works correctly and the main-menu is rendered
2. verify that it works for other applications without yarn.lock (this can be done by removing the yarn.lock and rebuilding the application). Else, you can reference dependencies by local paths: https://docs.npmjs.com/files/package.json#local-paths

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[akosyakov]

A short wrap-up why new momentjs breaks a command will help. I could not find a proper explanation in comments on the issue and here.

[vince-fugnitto]

A short wrap-up why new momentjs breaks a command will help. I could not find a proper explanation in comments on the issue and here.

I updated the issue, somehow my updates to the issue Saturday were never saved (where I narrowed down the bug to momentjs). I also found a relevant issue describing breaking changes on their part.

[kittaakos]

I could reproduce the issue, I could work around the issue by adding moment to the resolutions but there is no way to verify the fix before merging it. I propose merging it as it won't get any worse compared to the current state.

[kittaakos]

Thanks for the fix 👍

[vince-fugnitto]

Thanks for the fix 👍

Thank you very much for the review @kittaakos!