yangster: remove 'yangster' image #390
Conversation
|
Until eclipse-theia/theia#8315 (review) is merged and released at the end of the month, the |
@marcdumais-work we also have the #386 error to worry about before we can officially make use of the extension properly. |
vince-fugnitto
force-pushed
the
yangster
branch
3 times, most recently
from
961901f to
e61fee6
Compare
The `yangster-docker` image is removed since the `@theia/yangster` extension is deprecated in favor of supporting a vscode extension which provides language-features. The old extension used deprecated theia components which are no longer in use. The `yangster` vscode extension is added to `theia-full` (latest and next). Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
force-pushed
the
yangster
branch
from
e61fee6 to
65a0c6e
Compare
| @@ -316,6 +316,9 @@ yarn --cache-folder ./ycache && rm -rf ./ycache && \ | |||
| NODE_OPTIONS="--max_old_space_size=4096" yarn theia build && yarn theia download:plugins \ | |||
| ;fi | |||
|
|
|||
| # Change permissions to make the `yang-language-server` executable. | |||
There was a problem hiding this comment.
Paul's fix has been merged. We'll still need this work-around for latest until end of month.
|
I think |
What it does
Fixes: #388
The following pull-request includes updates to yangster.
The
yangster-dockerimage is removed since it makes use of the outdatedyangsterTheia-extension (which was replaced by theyang-vscodevscode extension. Thetheia-fullimage is updated to make use of the extension instead (so there is no need for the individual image anymore).How to test
The
yangster-dockerimage is removed so verify that there are no longer any references toyangsterbesides the new vscode extension. Thefull-imageshould now support the new extension.The build currently fails due to #386
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com