Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate extension manager #4876

Merged
merged 1 commit into from
Apr 16, 2019
Merged

deprecate extension manager #4876

merged 1 commit into from
Apr 16, 2019

Conversation

akosyakov
Copy link
Member

fix #4693

I've not found any references in docs and will remove it from theia-full image.

@akosyakov akosyakov mentioned this pull request Apr 11, 2019
Merged
@akosyakov
fix #4693: deprecate extension manager
aa8ebfa 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov requested a review from kittaakos April 11, 2019 08:49
@kittaakos
Copy link
Contributor

Why do not we delete the extension?

@akosyakov
Copy link
Member Author

Why do not we delete the extension?

We want to reuse it: https://github.com/theia-ide/theia/pull/4876/files#diff-95c0da6ee742fdb8fe813a2b4c935919R3

kittaakos
kittaakos approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not want to remove the source and want to compile it although it is unused; it looks good to me.

marcdumais-work
marcdumais-work approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Anton

@akosyakov akosyakov merged commit 2d0f27e into master Apr 16, 2019
@akosyakov akosyakov deleted the GH-4693 branch April 16, 2019 11:35
@vince-fugnitto vince-fugnitto mentioned this pull request Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcdumais-work marcdumais-work marcdumais-work approved these changes

@kittaakos kittaakos kittaakos approved these changes

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

@thegecko thegecko Awaiting requested review from thegecko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of references to extension-manager everywhere
3 participants
@akosyakov @kittaakos @marcdumais-work