Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S3 Storage] Refactor S3 (or S3-compatible) URL creation #649

Merged
merged 1 commit into from
Sep 22, 2023
Merged

[S3 Storage] Refactor S3 (or S3-compatible) URL creation #649

merged 1 commit into from
Sep 22, 2023

Conversation

rzvoncek
Copy link
Contributor

@rzvoncek rzvoncek commented Sep 21, 2023 •
edited
Loading

Fixes #621 .

@rzvoncek rzvoncek force-pushed the radovan/s3-url-refactor branch 5 times, most recently from 9b619bc to 5d3a018 Compare September 21, 2023 11:42
@rzvoncek rzvoncek force-pushed the radovan/s3-url-refactor branch from 5d3a018 to 31c0798 Compare September 21, 2023 11:57
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #649 (31c0798) into master (951b127) will increase coverage by 0.28%.
The diff coverage is 96.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   79.21%   79.49%   +0.28%     
==========================================
  Files          52       52              
  Lines        4464     4473       +9     
  Branches      651      651              
==========================================
+ Hits         3536     3556      +20     
+ Misses        895      884      -11     
  Partials       33       33
Files Changed Coverage Δ
medusa/storage/s3_base_storage.py 93.50% <96.96%> (+5.01%) ⬆️

... and 1 file with indirect coverage changes

@rzvoncek rzvoncek marked this pull request as ready for review September 21, 2023 13:18
@rzvoncek rzvoncek added the ready-for-review Issues in the state 'ready-for-review' label Sep 21, 2023
@rzvoncek rzvoncek merged commit 7013331 into master Sep 22, 2023
@rzvoncek rzvoncek deleted the radovan/s3-url-refactor branch September 22, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adejanovski adejanovski adejanovski approved these changes

Assignees
No one assigned
Labels
ready-for-review Issues in the state 'ready-for-review'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactoring: s3 base storage - move url creation to a method
2 participants
@rzvoncek @adejanovski