Fix cluster name check in repair concurrency control #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
force-pushed
the
fix-concurrent-repairs-cluster-compare
branch
from
ad03e1e
to
391d74a
Compare
burmanm
previously approved these changes
Jul 18, 2023
adejanovski
force-pushed
the
fix-concurrent-repairs-cluster-compare
branch
from
391d74a
to
54c3cc1
Compare
burmanm
approved these changes
Jul 19, 2023
adejanovski
added a commit
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1319
An
==operator was used to filter the active RepairRunner instances based on the cluster name.That will obviously give unexpected results, which was allowing all repairs to run concurrently instead of respecting the maxParallelRepairs limit.
This is fixed by this PR and the code that applies the filtering has been refactored to allow it being tested.