Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getTokenEndpointMap and getEndpointToHostId, fix getTokens #1373

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

emerkle826
Copy link
Collaborator

@emerkle826 emerkle826 commented Aug 31, 2023

Fixes #1378
Fixes #1387

@emerkle826
Copy link
Collaborator Author

NOTE: This still needs k8ssandra/management-api-for-apache-cassandra#377 to be merged and then a new client generated. Currently, this PR is using a client compiled from that PR branch.

@emerkle826 emerkle826 marked this pull request as ready for review September 11, 2023 22:11
@Miles-Garnsey Miles-Garnsey changed the title Implement getTokenEndpointMap and getEndpointToHostId Implement getTokenEndpointMap and getEndpointToHostId, fix getTokens Sep 12, 2023
Copy link
Contributor

@Miles-Garnsey Miles-Garnsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I should have picked this up before, but I can't see unit tests for the two new methods. The unit test for getTokens appears to be right, but we need some for getRangeToEndpointMap and getTokenToEndpointMap

@Miles-Garnsey Miles-Garnsey merged commit 3de122b into integration/http-managementproxy Sep 13, 2023
17 of 20 checks passed
@emerkle826 emerkle826 deleted the feature/token-methods branch September 13, 2023 15:13
Miles-Garnsey added a commit that referenced this pull request Oct 3, 2023
…1373)

* Implement getTokenEndpointMap.
* Fix getTokens
* Implement getEndpointToHostId.

---------

Co-authored-by: Miles-Garnsey <miles.garnsey@datastax.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants