-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getTokenEndpointMap and getEndpointToHostId, fix getTokens #1373
Implement getTokenEndpointMap and getEndpointToHostId, fix getTokens #1373
Conversation
e76ae9b
to
72a118a
Compare
NOTE: This still needs k8ssandra/management-api-for-apache-cassandra#377 to be merged and then a new client generated. Currently, this PR is using a client compiled from that PR branch. |
src/server/src/main/java/io/cassandrareaper/management/http/HttpCassandraManagementProxy.java
Show resolved
Hide resolved
72a118a
to
e94b380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I should have picked this up before, but I can't see unit tests for the two new methods. The unit test for getTokens appears to be right, but we need some for getRangeToEndpointMap
and getTokenToEndpointMap
src/server/src/main/java/io/cassandrareaper/management/http/HttpCassandraManagementProxy.java
Show resolved
Hide resolved
src/server/src/main/java/io/cassandrareaper/management/http/HttpCassandraManagementProxy.java
Show resolved
Hide resolved
64b8133
to
f7f2309
Compare
f7f2309
to
2deccec
Compare
3de122b
into
integration/http-managementproxy
…1373) * Implement getTokenEndpointMap. * Fix getTokens * Implement getEndpointToHostId. --------- Co-authored-by: Miles-Garnsey <miles.garnsey@datastax.com>
Fixes #1378
Fixes #1387