-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HTTP based getToken, getEndpointToHostId, getLocalEndpoint #1376
Merged
Miles-Garnsey
merged 2 commits into
integration/http-managementproxy
from
feature/gettokens-getrangetoendpointmap-getlocalendpoint
Sep 7, 2023
Merged
Implement HTTP based getToken, getEndpointToHostId, getLocalEndpoint #1376
Miles-Garnsey
merged 2 commits into
integration/http-managementproxy
from
feature/gettokens-getrangetoendpointmap-getlocalendpoint
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
changed the base branch from
master
to
integration/http-managementproxy
September 5, 2023 00:51
Miles-Garnsey
changed the title
Implement HTTP based getTokens, getRangeToEndpointMap, getLocalEndpoint
Implement HTTP based getToken, getLocalEndpoint
Sep 5, 2023
Miles-Garnsey
changed the title
Implement HTTP based getToken, getLocalEndpoint
Implement HTTP based getToken, getHostIdToEndpoint, getLocalEndpoint
Sep 5, 2023
Miles-Garnsey
changed the title
Implement HTTP based getToken, getHostIdToEndpoint, getLocalEndpoint
Implement HTTP based getToken, getEndpointToHostId, getLocalEndpoint
Sep 5, 2023
burmanm
reviewed
Sep 5, 2023
src/server/src/main/java/io/cassandrareaper/management/http/HttpCassandraManagementProxy.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Sep 5, 2023
emerkle826
requested changes
Sep 5, 2023
src/server/src/main/java/io/cassandrareaper/management/http/HttpCassandraManagementProxy.java
Outdated
Show resolved
Hide resolved
Miles-Garnsey
force-pushed
the
feature/gettokens-getrangetoendpointmap-getlocalendpoint
branch
from
September 6, 2023 00:46
3fdcc9b
to
bccdc9c
Compare
emerkle826
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you get the checkstyle stuff fixed, this is good to go.
Miles-Garnsey
force-pushed
the
feature/gettokens-getrangetoendpointmap-getlocalendpoint
branch
from
September 7, 2023 01:16
bccdc9c
to
9b10406
Compare
…CassandraManagementProxy.getLocalEndpoint()
Miles-Garnsey
force-pushed
the
feature/gettokens-getrangetoendpointmap-getlocalendpoint
branch
from
September 7, 2023 01:37
9b10406
to
4599249
Compare
Miles-Garnsey
merged commit Sep 7, 2023
bc51516
into
integration/http-managementproxy
18 of 20 checks passed
Miles-Garnsey
added a commit
that referenced
this pull request
Oct 3, 2023
…#1376) * Implement HttpCassandraManagementProxy.getEndpointToHostId(), HttpCassandraManagementProxy.getLocalEndpoint(), HttpCassandraManagementProxy.getTokens()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1377
Fixes #1379
Fixes #1380