Remove close from proxy interface #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
approved these changes
Sep 8, 2023
adejanovski
merged commit 89d1369
into
integration/http-managementproxy
18 of 20 checks passed
Miles-Garnsey
pushed a commit
that referenced
this pull request
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1385
close()is really only called by the JMX implementation to get rid of stale JMX connections. We son't have that situation with the Management API client, nor is there any real way to close the client. So this essentially refactors the parent interface to removeclose()and only implement it within the JMX proxy and factory classes.