Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker config for HTTP management interface #1425

Merged

Conversation

Miles-Garnsey
Copy link
Contributor

The Docker config file needs to be updated so that an environment variable can be used to set whether the HTTP management interface is enabled (which replaces the JMX interface)

Fixes issue

#1424

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@Miles-Garnsey Miles-Garnsey changed the base branch from master to integration/http-managementproxy October 5, 2023 00:19
Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but you'll need to rebase on top of the integration branch first it seems. There are a lot of commits here that don't belong to this PR.

… HTTP management proxy can be enabled via environent variable, instead of only through the config file.
@Miles-Garnsey
Copy link
Contributor Author

This looks good, but you'll need to rebase on top of the integration branch first it seems. There are a lot of commits here that don't belong to this PR.

Done, not sure what happened there sorry!

…her config file, trying putting some more carriage returns in to cater to this.
@Miles-Garnsey Miles-Garnsey merged commit 821d106 into integration/http-managementproxy Oct 11, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants