Fix incorrect callback function #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Hi @upsilon2gamma,
you're right, in case of error there's some duplication of timers that will happen.
May I suggest that we keep the complete: callback and modify the error: one by removing the this.component.setState(... line, keeping just the console logging?
This way we'll remove some unnecessary lines of code.
Thanks!
https://api.jquery.com/jQuery.ajax/ According to JQuery doc, `complete` will be called whether the ajax request succeeds or fails. As a result, `_refreshClusterStatus` will generates two new scheduled calls if the ajax request gets an error response (one by `error` and one by `complete`). If `_refreshClusterStatus` keeps getting error responses (e.g. token has expired), it will generate a huge number of requests (doubles every 30s)
upsilon2gamma
force-pushed
the
fix-refreshClusterStatus
branch
from
dfefdc8
to
b0d7f7e
Compare
|
@adejanovski Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1442
According to JQuery doc (https://api.jquery.com/jQuery.ajax/),
completefunction will be called whether the ajax request succeeds or fails. As a result,_refreshClusterStatuswill set two new scheduled calls if the ajax request gets an error response (the first one byerrorand the second one bycomplete).If
_refreshClusterStatuskeeps getting error responses (e.g. token has expired, the ajax request always gets 304 response), it will generate a huge number of requests in 10min (doubles every 30s)