Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADS-4131 update reporting format #26

Merged
merged 3 commits into from
Jun 29, 2020
Merged

ADS-4131 update reporting format #26

merged 3 commits into from
Jun 29, 2020
+206 −29

Commits on Jun 26, 2020

  1. ADS-4131 Discard events if the script fails to load 

    If the Maven Distribution (LiftIgniter) script fails to load, then discard events instead of buffering forever.
    @yonran
    yonran committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a249ecd View commit details
    Browse the repository at this point in the history

  2. Include timing info in pbjs_debug=true console log 

    Include the number of milliseconds since the page load
    @yonran
    yonran committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    e518420 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. ADS-4131 Change the format of LiftIgniter activity 

    Instead of cpm (price per 1000 impressions), send cpmm (price per 1 million impressions). Also include a price field that sums all the cpmms in the batc.
    @yonran
    yonran committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    90c3e50 View commit details
    Browse the repository at this point in the history