Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.4.0 font issue #1165

Closed
6 of 12 tasks
kneep opened this issue Sep 13, 2019 · 12 comments
Closed
6 of 12 tasks

v7.4.0 font issue #1165

kneep opened this issue Sep 13, 2019 · 12 comments

Comments

@kneep
Copy link

kneep commented Sep 13, 2019

I agree and want to create new issue


Expected behavior

Actual behavior

The font size of posts built with v7.4.0 is much larger than before.

Steps to reproduce the behavior

  1. Build a site with v7.4.0
  2. N/A
  3. N/A
  • Link to demo site with this bug: N/A
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information


Package dependencies Information


Hexo Information

Hexo version

3.9.0

Hexo Configuration

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

Other Information

v7.3.0 is OK.
I noticed the font size of https://theme-next.org/ is also very large. Maybe it looks OK for English but not for Chinese.

@kneep kneep added the Bug label Sep 13, 2019
@welcome
Copy link

welcome bot commented Sep 13, 2019

Thanks for opening this issue, maintainers will get back to you as soon as possible!

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label Bug to this issue, with a confidence of 0.85. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@kneep
Copy link
Author

kneep commented Sep 13, 2019

Another thing I noticed was that from v7.2.0 to v7.3.0, font size of post title was increased but not the that of the body. I'm not sure whether these size changes were inadvertent. Anyway I think the font size from earlier version to v7.2.0 worked much better for me.

BTW, I tried the override the font size of body in _config.yml but seemed not work.

# Font settings for posts (.post-body).
  posts:
    external: true
    family:
    size: 0.9

The 'size' line was not in the template. I'm not sure if this works.

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Sep 15, 2019

I'm not sure whether these size changes were inadvertent.

#1005, #1006, #1086

@kneep
Copy link
Author

kneep commented Sep 16, 2019

@stevenjoezhang Hi Steven. I mean the font size of a post-body is relatively large compared to other parts. How can I adjust the post-body font size independently in _config.yml?

@stevenjoezhang
Copy link
Contributor

Use custom stylesheet:

.post-body { font-size: /*  */; }

@kneep
Copy link
Author

kneep commented Sep 16, 2019

@stevenjoezhang

Hi Steven.

I did some test for this. Seems it is caused by the following code:

source/css/_common/components/post/post.styl

+desktop-large() {
  font-size: $font-size-large;
}

If I changed font-size-large to font-size-medium, everything was OK.

So I took a look at the definition:

source/css/_mixins/base.styl

desktop-large() {
  @media (min-width: 1200px) {
    {block};
  }
}

So the problem here is: my screen was 1366*768, how did I get into the 1200px config?

@stevenjoezhang
Copy link
Contributor

Don't worry, we're dealing with it: #1190

@stevenjoezhang
Copy link
Contributor

Font size has been adjusted in v7.4.1

@kneep
Copy link
Author

kneep commented Nov 1, 2019

I just tested v7.4.3 and don't think it fixed my problem.

I think the problem is:
source/css/_common/components/post/post.styl

+desktop-large() {
    font-size: $font-size-large;
  }

where the font-size-large is too large for a laptop(either normal or high resolution screen).
I have to change it to font-size-medium to make it look better.

@lingjiameng
Copy link

lingjiameng commented Dec 15, 2019

I found this error too for zh-CN
image
but in my local host server, it's
image
How this can happen?

@LemniscateX
Copy link

I just tested v7.4.3 and don't think it fixed my problem.

I think the problem is:
source/css/_common/components/post/post.styl

+desktop-large() {
    font-size: $font-size-large;
  }

where the font-size-large is too large for a laptop(either normal or high resolution screen).
I have to change it to font-size-medium to make it look better.

I feel the same.🙌🏻
My solution is to change the $font-size-large value from 1.125em to 1em, just to prevent manually change EVERY content from $font-size-large to $font-size-medium, which is less easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants