Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all hardcoded font sizes #1005

Merged
merged 9 commits into from
Jul 25, 2019
Merged

Remove all hardcoded font sizes #1005

merged 9 commits into from
Jul 25, 2019

Conversation

stevenjoezhang
Copy link
Contributor

Two steps

  1. Remove all hardcoded font sizes
  2. Use em instead of px

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9
Copy link
Member

1v9 commented Jul 24, 2019

Must be the last PR for font-refacctoring 😂

@stevenjoezhang
Copy link
Contributor Author

The first one was opened four months ago: #689

@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 24, 2019
@stevenjoezhang
Copy link
Contributor Author

Theoretically, this PR does not bring significant visual changes

@1v9
Copy link
Member

1v9 commented Jul 25, 2019

post-title h2 这个把我搞晕了,字体太小了

@stevenjoezhang
Copy link
Contributor Author

除了Gemini,其它scheme的post-title都设计的比较小

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants