Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About code font size. #687

Closed
4 of 11 tasks
gapplef opened this issue Mar 14, 2019 · 5 comments
Closed
4 of 11 tasks

About code font size. #687

gapplef opened this issue Mar 14, 2019 · 5 comments

Comments

@gapplef
Copy link

gapplef commented Mar 14, 2019

I agree and want to create new issue


According to my understand, current NexT theme set the code font size($code-font-size) to a fix value 14px, while the font of article body is set to changes according to the screen size(-4px, -2px, +2px, +4px), with base font($font-size-base) also set to 14px.

$code-font-size = 14px
$code-font-size = unit(hexo-config('font.codes.size'), px) if hexo-config('font.codes.size') is a 'unit'

$font-size-base = 14px
$font-size-base = unit(hexo-config('font.global.size'), px) if hexo-config('font.global.size') is a 'unit'
$font-size-small = $font-size-base - 2px
$font-size-smaller = $font-size-base - 4px
$font-size-large = $font-size-base + 2px
$font-size-larger = $font-size-base + 4px

This means the font size of code could be same with, smaller or larger than the article body font in different case. I don't think this is appropriate, especially for the inline code.

It's very common to use inline code to highlight keywords, like in the office documentation. I think size of these keywords should be same with the article body.

To sum up, I would like the font size of code always same with the article body, especially for inline code. How to config the NexT theme?

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini
@gapplef gapplef added the Bug label Mar 14, 2019
@stevenjoezhang
Copy link
Contributor

Temporary solution: delete this line

@gapplef
Copy link
Author

gapplef commented Mar 14, 2019

@stevenjoezhang here seems miss : ?

@stevenjoezhang
Copy link
Contributor

Emm... I'll open a PR to fix it...

@gapplef
Copy link
Author

gapplef commented Mar 14, 2019

Great jobs! Appreciate for your quick response.

@stevenjoezhang
Copy link
Contributor

Fixed in #1005, #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants