Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Valine options #1193

Merged
merged 1 commit into from
Oct 1, 2019
Merged

New Valine options #1193

merged 1 commit into from
Oct 1, 2019

Conversation

kuretru
Copy link
Contributor

@kuretru kuretru commented Oct 1, 2019

PR Checklist

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

valine:
   recordIP: true # Whether to record the commenter IP
   serverURLs: https://api.your_domian.com # When the custom domain name is enabled, fill it in here (itwill be detected automatically by default, no need to fill in)

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Oct 1, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

@1v9 1v9 added the ⭐ Feature label Oct 1, 2019
@1v9 1v9 added this to the v7.4.2 milestone Oct 1, 2019
@1v9
Copy link
Member

1v9 commented Oct 1, 2019

Seems fine, any demo?

@kuretru
Copy link
Contributor Author

kuretru commented Oct 1, 2019

Seems fine, any demo?

Sure, there is my config in _config.yml:

valine:
  recordIP: true
  serverURLs: https://api.blog.i5zhen.com

For serverURLs:

  1. Open my blog: https://blog.kuretru.com/posts/bb1d45aa.html .
  2. Open the Console -> Network tab in Chrome, you can see some XHR request like "/Comment?where=xxxxxxx"
  3. The request host is "https://api.blog.i5zhen.com/1.1/classes/Comment?where=xxxxxxx", which is set in my config.

For recordIP:

呉真的博客
呉真的博客近2年没有更新了,现在打算重新做起来。考虑到基于PHP的WordPress不能完全静态化,因此打算重新寻找博客系统,在试用Hexo后,非常爱不释手,当即决定使用Hexo最为新的博客系统,主要考虑到以下几个原因。

@1v9 1v9 changed the title Add some new configuration item with Valine comments New Valine options Oct 1, 2019
@1v9 1v9 merged commit 67fa917 into theme-next:master Oct 1, 2019
@welcome
Copy link

welcome bot commented Oct 1, 2019

Congrats on merging your first pull request here! 🎉 How awesome!

@1v9
Copy link
Member

1v9 commented Oct 1, 2019

@all-contributors please add @kuretru for code, doc

@allcontributors
Copy link
Contributor

@1v9

I've put up a pull request to add @kuretru! 🎉

@kuretru
Copy link
Contributor Author

kuretru commented Oct 1, 2019

Thanks for @1v9 .

@1v9
Copy link
Member

1v9 commented Oct 1, 2019

@kuleyu 可以来 TG 群里吹逼

@1v9 1v9 modified the milestones: v7.5.0, 7.4.2 Oct 20, 2019
@pzb568
Copy link

pzb568 commented Oct 20, 2019

Valine没有绑定域名,是不是就不能使用了呢

@kuretru
Copy link
Contributor Author

kuretru commented Oct 20, 2019

Valine没有绑定域名,是不是就不能使用了呢
@pzb568
根据官方文档,这个选项不设置的话,会自动检测并配置。
提示:旧版本的Valine确实存在bug,可以手动指定Valine版本至1.3.10+

Liam0205 added a commit to Liam0205/hexo-theme-next that referenced this pull request Oct 22, 2019
- Add Google Analytics Pageview (theme-next#1198)

- Make font-size customized only when `theme.font.enable` is true (theme-next#1058)
- Point to different website based on the scheme (theme-next#1202)
- New Valine options (theme-next#1193)
- Improve the style of site-nav (theme-next#1180)

- Code style update (theme-next#1197, theme-next#1205)
- Replace id with class name (theme-next#1209)
- Add lang attribute to article tag when specified in front matter (theme-next#1199)
- Fix compatibility issues with hexo-util@1.3.0 (theme-next#1175)
- Optimize the loading of three.js (theme-next#1140)

- New README for NexT (theme-next#1155)

***

For full changes, see the [comparison between v7.4.1 and v7.5.0](theme-next/hexo-theme-next@v7.4.1...v7.5.0)
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants