Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make author image optional #1263

Conversation

matheusgeres
Copy link
Contributor

@matheusgeres matheusgeres commented Nov 6, 2019

PR Checklist

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Currently in docs there is a behavior that includes doesn't show author image when is not present. But even not present im YAML an image is rendering.

Issue resolved: N/A

What is the new behavior?

Author image is showing only there is a author image on YAML.

How to use?

In Hexo next.yml don't include avatar.url

Does this PR introduce a breaking change?

  • Yes.
  • No.

@welcome
Copy link

welcome bot commented Nov 6, 2019

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2019

CLA assistant check
All committers have signed the CLA.

@stevenjoezhang stevenjoezhang added this to the v7.6.0 milestone Nov 8, 2019
@stevenjoezhang stevenjoezhang changed the title Reinsert remove if for remove author image. Make author image optional Nov 8, 2019
@stevenjoezhang stevenjoezhang merged commit e735db4 into theme-next:master Nov 8, 2019
@welcome
Copy link

welcome bot commented Nov 8, 2019

Congrats on merging your first pull request here! 🎉 How awesome!

tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants