Use IntersectionObserver to lazyload comments #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/theme-next/hexo-next-utteranc/blob/6f841a67c9d12f1453be8269abb6307862542753/index.js#L21 It only has a <script>. Although it can be changed, it is a bit annoying. Anyway, just lazy loading doesn't work, no other effect.
|
sli1989
reviewed
Jan 14, 2020
| NexT.utils.getScript('{{ valine_uri }}', () => { | ||
| var GUEST = ['nick', 'mail', 'link']; | ||
| var guest = '{{ theme.valine.guest_info }}'; | ||
| guest = guest.split(',').filter(item => { | ||
| return GUEST.includes(item); | ||
| }); | ||
| new Valine({ | ||
| el: '#comments', | ||
| el: '#valine-comments', |
There was a problem hiding this comment.
this makes the hyperlink doesn't working.
sli1989
added a commit
to sli1989/hexo-theme-next
that referenced
this pull request
Jan 14, 2020
stevenjoezhang
pushed a commit
that referenced
this pull request
Jan 22, 2020
|
有没有可能都变成 |
stevenjoezhang
referenced
this pull request
in next-theme/hexo-theme-next
Jul 23, 2020
voidking
pushed a commit
to voidking/hexo-theme-next-2021
that referenced
this pull request
Oct 28, 2020
voidking
pushed a commit
to voidking/hexo-theme-next-2021
that referenced
this pull request
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the new behavior?
Does this PR introduce a breaking change?