Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove baidushare support #967

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Remove baidushare support #967

merged 1 commit into from
Jul 12, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 12, 2019

Breaking Change

-# Baidu Share (does not support https).
-baidushare:
-  #type: button
-  #type: slide

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

  • Baidu Share does not support https website
  • Baidu Share does not match the description Next is an elegant theme

References:
https://www.v2ex.com/t/413283
https://www.v2ex.com/t/128414
https://www.zhihu.com/question/20241311/answer/14503125

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

Does this PR introduce a breaking change?

  • Yes.
  • No.

@sli1989
Copy link
Collaborator

sli1989 commented Jul 12, 2019

it's better to add description of the reasson.

@stevenjoezhang stevenjoezhang merged commit a21b352 into master Jul 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the baidu branch July 12, 2019 13:41
@liolok liolok changed the title Remove baidushare Remove baidushare support Jul 31, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 9, 2019
3 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants