Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache sidebar site-overview #971

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Cache sidebar site-overview #971

merged 3 commits into from
Jul 15, 2019

Conversation

jiangtj
Copy link
Member

@jiangtj jiangtj commented Jul 13, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

#545
#539
#661

Does this PR introduce a breaking change?

  • Yes.
  • No.

@jiangtj jiangtj changed the title Cache, let's cache sidebar, scripts and 3rd-party's etc Cache sidebar site-overview Jul 13, 2019
@jiangtj
Copy link
Member Author

jiangtj commented Jul 13, 2019

Add a little cache, this time just the sidebar.... 😂

@jiangtj jiangtj added this to the v7.3.0 milestone Jul 13, 2019
@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Jul 13, 2019 •
edited
Loading

#547

等Hexo处理 hexojs/hexo#3624

如果合并了，需要revert以下两个PR
#42
#87

@jiangtj
Copy link
Member Author

jiangtj commented Jul 13, 2019 •
edited by unfurl-links bot
Loading

#547

Tested in https://jiangtj.gitlab.io/next-test/gemini/, TOC is OK, because I don't cache it.

我知道有许多地方需要缓存，但是一点点来会更好，避免出错。。。
I know there are many places that need to be cached, but it will be better in a little bit to avoid mistakes. . .
😟

Hexo
Test WebSite for four schemes in Next

@Liam0205
Copy link
Contributor

test report:

GJ! thanks @jiangtj

@Liam0205
Copy link
Contributor

BTW, next time, you could notify me on GitHub issue. @jiangtj

@jiangtj
Copy link
Member Author

jiangtj commented Jul 15, 2019

BTW, next time, you could notify me on GitHub issue. @jiangtj

😂 Okay, thank you for your test.

Others still need to be cached, it is expected to be around 1min. Waiting next time.

@jiangtj jiangtj merged commit a362d70 into master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the cache branch July 15, 2019 11:34
This was referenced Jul 16, 2019
Closed
Closed
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@jiangtj
Cache sidebar site-overview (theme-next#971)
3a1dd62 
* Move head point, it can be set cache in options

* cache site-overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@ivan-nginx ivan-nginx Awaiting requested review from ivan-nginx

@maple3142 maple3142 Awaiting requested review from maple3142

@sli1989 sli1989 Awaiting requested review from sli1989

Assignees
No one assigned
Labels
🛠 Improvement ⏱ Performance
Projects
None yet
Milestone
v7.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangtj @stevenjoezhang @Liam0205