Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor comments using theme_inject #998

Merged
merged 7 commits into from
Jul 26, 2019
Merged

Conversation

jiangtj
Copy link
Member

@jiangtj jiangtj commented Jul 23, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

Tested process

  • disqus
  • disqusjs
  • facebook
  • livere
  • gitalk
  • changyan (无法备案)
  • valine (不想实名)
  • vk (blocked user)

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the new behavior?

  • Use the injection method to implement the comment system.
  • Lay the foundation for the multi-comment system.
  • Make it easier to plugin

Does this PR introduce a breaking change?

  • Yes.
  • No.

@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@theme-next theme-next deleted a comment Jul 24, 2019
@jiangtj
Copy link
Member Author

jiangtj commented Jul 24, 2019

Complexity increasing per file

let theme = hexo.theme.config; is only used in filter, not outside...

@jiangtj jiangtj marked this pull request as ready for review July 24, 2019 07:30
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 24, 2019
@jiangtj jiangtj removed this from the v7.3.0 milestone Jul 25, 2019
@jiangtj
Copy link
Member Author

jiangtj commented Jul 25, 2019

@stevenjoezhang 蜜汁赞同,都还没测完 😂

It's not finished test yet 😂

@theme-next theme-next deleted a comment Jul 26, 2019
@theme-next theme-next deleted a comment Jul 26, 2019
@theme-next theme-next deleted a comment Jul 26, 2019
@jiangtj jiangtj added this to the v7.3.0 milestone Jul 26, 2019
@jiangtj jiangtj merged commit 9f1f27a into theme-next:master Jul 26, 2019
@jiangtj jiangtj deleted the comments branch July 26, 2019 06:10
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* Refactor comments

* Use partial insteal of macro

* Fix QA

* Fix QA

* Refactor priority

* Format inject point
@sli1989
Copy link
Collaborator

sli1989 commented Mar 29, 2020

an alter way to rename the post meta of comment for chinese:

for example with valine

  1. creat a languages.yml in source\_data. (data files' way)
  2. insert following codes: (be carefully about the two-space indent)
zh-CN:
  post:
    comments:
      valine:  评论

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants