Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds alpha option to multicolor control #1449

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

danielortiz
Copy link
Contributor

ref #1321
I also needed this, so I implemented it.

One difference from the color control is that it passes the alpha argument inside the choicesarg, like

'choices' => array(
    'alpha' => true,
),

but as multicolor is already using 'choices' arg for color options, I put it on the $args root. Just let me know if you have a better idea.

Another difference from color control is that alpha is disabled by default there. That's a case where one would have to choose between consistency and legacy support. I've chosen legacy here and set it as enabled by default, let me know if you think it should be the opposite.

@AdsonCicilioti
Copy link

Good feature!

Hey @danielortiz !

We need to help @aristath take the kirki to an even better level than it already is. But I have a small level in PHP.

I have felt limitations in using the repeater, as I see it as a very powerful field, but limited because it does not yet support all of Kirki's fields.

But I believe that with a few lines of code we can do it, for example, to enable the multicolor field ... The color field, for example, does not accept the alpha skill inside a repeater. These and other adjustments could make Kirki's repeater a Rocket!

@danielortiz
Copy link
Contributor Author

Hi, @AdsonCicilioti. I'm not really familiar with the repeater control, but sure, I can take a look :), and yea, I see it'd be useful.

Something that I DID need was a reorderable repeater.

@aristath
Copy link
Contributor

aristath commented Jul 3, 2017

Hey there!

I haven't had a chance to review this yet, I'll do it later today.

As for the repeater, the rows ARE sortable 😄

@danielortiz
Copy link
Contributor Author

@aristath really? that's great..I didn't actually test it and I assumed they weren't looking at the screenshot..sorry

@aristath
Copy link
Contributor

aristath commented Jul 4, 2017

Merged 👍

@aristath aristath merged commit 2e3d8c0 into themeum:develop Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants