Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add 〜まい form #1361

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[ja] add 〜まい form #1361

merged 2 commits into from
Aug 27, 2024

Conversation

khaitruong922
Copy link

@khaitruong922 khaitruong922 commented Aug 27, 2024

Closes #1358

@khaitruong922 khaitruong922 requested a review from a team as a code owner August 27, 2024 07:06
Copy link

codspeed-hq bot commented Aug 27, 2024

CodSpeed Performance Report

Merging #1361 will not alter performance

Comparing khaitruong922:mai-form (85cd795) with master (601633e)

Summary

✅ 3 untouched benchmarks

🆕 2 new benchmarks
⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master khaitruong922:mai-form Change
⁉️ japanese transformations (n=59) 15.3 ms N/A N/A
🆕 japanese transformations (n=61) N/A 16.1 ms N/A
⁉️ japanese transformations-full (n=160) 34.4 ms N/A N/A
🆕 japanese transformations-full (n=166) N/A 36.2 ms N/A

Copy link
Collaborator

@Casheeew Casheeew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Casheeew Casheeew added this pull request to the merge queue Aug 27, 2024
@Casheeew Casheeew added area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request labels Aug 27, 2024
Merged via the queue into themoeway:master with commit b743399 Aug 27, 2024
10 of 11 checks passed
@khaitruong922 khaitruong922 deleted the mai-form branch August 27, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ja] - add ~まい form
2 participants