save options after updating them #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_optionsUtil.save() is only called in _saveOptions, which is only called through - _onApiSetAllSettings - _onApiModifySettings - _onCommandToggleTextScanning it should be safe to simply save settings after updating them. without saving, the options will be updated every time the background restarts, until any settings are modified or text scanning is toggled. for _updateVersion21, this means the welcome page will open repeatedly to show the same warning.
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
reviewed
Oct 24, 2023
djahandarie
approved these changes
Oct 24, 2023
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without saving, the options will be updated every time the background restarts, until any settings are modified or text scanning is toggled. for
_updateVersion21, this means the welcome page will open repeatedly to show the same warning._optionsUtil.save()is only called in_saveOptions, which is only called through_onApiSetAllSettings_onApiModifySettings_onCommandToggleTextScanningit should be safe to simply save settings after updating them.