Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profile switching keyboard shortcuts #832

Merged
merged 10 commits into from
Apr 22, 2024

Conversation

StefanVukovic99
Copy link
Member

Resolves #816

@StefanVukovic99 StefanVukovic99 requested a review from a team as a code owner April 16, 2024 19:24
Copy link

github-actions bot commented Apr 16, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Apr 16, 2024
@StefanVukovic99 StefanVukovic99 changed the title add profile switching add profile switching keyboard shortcuts Apr 18, 2024
jamesmaa
jamesmaa previously approved these changes Apr 18, 2024
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems sound. Just not sure if we're picking the best hotkeys. Maybe it doesn't matter?

@jamesmaa
Copy link
Collaborator

Conflict

* duplicate behavior dropdown

* allow duplicate for existing users

* Update docs/anki-integration.md

Co-authored-by: James Maa <jmaa@berkeley.edu>
Signed-off-by: StefanVukovic99 <stefanvukovic44@gmail.com>

* Update docs/anki-integration.md

Co-authored-by: James Maa <jmaa@berkeley.edu>
Signed-off-by: StefanVukovic99 <stefanvukovic44@gmail.com>

* Update docs/anki-integration.md

Co-authored-by: James Maa <jmaa@berkeley.edu>
Signed-off-by: StefanVukovic99 <stefanvukovic44@gmail.com>

* remove suggestion comment

---------

Signed-off-by: StefanVukovic99 <stefanvukovic44@gmail.com>
Co-authored-by: James Maa <jmaa@berkeley.edu>
@jamesmaa jamesmaa added this pull request to the merge queue Apr 22, 2024
Merged via the queue into themoeway:master with commit f0196aa Apr 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where is the shortcut option for switching between profiles?
3 participants