Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to bulk generate anki cards #895

Merged
merged 60 commits into from
May 12, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented May 8, 2024

Currently supports exporting a list of words either directly to Anki or to Anki's Notes in plain text file format.

Tested on Firefox and Chromium.

Demo:

untitled.mp4

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels May 8, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner May 8, 2024 23:46
@Kuuuube Kuuuube marked this pull request as draft May 8, 2024 23:46
Copy link

github-actions bot commented May 8, 2024

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@donkuri
Copy link

donkuri commented May 9, 2024

Concretely speaking, does that mean it would take in as input a list of word in Japanese and export different cards that way?

@Kuuuube
Copy link
Member Author

Kuuuube commented May 9, 2024

Concretely speaking, does that mean it would take in as input a list of word in Japanese and export different cards that way?

Yep

@Kuuuube Kuuuube marked this pull request as ready for review May 9, 2024 20:33
Copy link
Collaborator

@jamesmaa jamesmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't fully grok everything that's happening but i think this is stable enough to put in dev

@jamesmaa jamesmaa added this pull request to the merge queue May 12, 2024
Merged via the queue into themoeway:master with commit 486eec1 May 12, 2024
11 checks passed
@brishtibheja
Copy link

Nice. Can we also expect to be generating cards a/c to their frequency? Could create some custom decks for rarer languages.

@Kuuuube
Copy link
Member Author

Kuuuube commented May 12, 2024

Nice. Can we also expect to be generating cards a/c to their frequency? Could create some custom decks for rarer languages.

Don't comment things like this on closed prs. If you would like to request a feature, create an issue.

While this isn't directly supported at the moment and I don't have plans to add it myself yet, the frequency dict format is very simple so it is easy to manually pull the word list out of a frequency dict so you can paste it into the card generator if you wanted to.

@brishtibheja
Copy link

If you would like to request a feature, create an issue.

No I was not requesting anything. I asked here as it was a Yes/No question. Who thought TMW has such a strict code of ethics /hj

@Kuuuube
Copy link
Member Author

Kuuuube commented May 12, 2024

Who thought TMW has such a strict code of ethics

Nothing strict here it's just a bit messy when prs get commented up after they're merged. For future reference, questions like this are best asked in the TMW discord #yomitan-development or the github discussions.

@brishtibheja
Copy link

Oh sorry I genuinely forgot about github discussions. I'll keep this in mind next time. Please censure me once again if I forget.

@jamesmaa jamesmaa mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants